Skip to content

Remove the missing attribute mapping warning popup.#9459

Open
PasinduYeshan wants to merge 1 commit intowso2:masterfrom
PasinduYeshan:fixm/attr-map1
Open

Remove the missing attribute mapping warning popup.#9459
PasinduYeshan wants to merge 1 commit intowso2:masterfrom
PasinduYeshan:fixm/attr-map1

Conversation

@PasinduYeshan
Copy link
Contributor

@PasinduYeshan PasinduYeshan commented Nov 23, 2025 •
edited by coderabbitai bot
Loading

Purpose

$subject

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Developer Checklist (Mandatory)

  • Complete the Developer Checklist in the related product-is issue to track any behavioral change or migration impact.

Summary by CodeRabbit

  • User Interface

    • Removed warning alerts previously displayed for unmapped user stores within the claims management interface.
    • Simplified the visual presentation of local claims for improved clarity.

  • Refactor

    • Cleaned up internal claim handling and rendering logic.
    • Removed deprecated user store mapping verification functionality and associated utilities.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 23, 2025 •
edited
Loading

Walkthrough

A claims list component underwent cleanup: the checkUserStoreMapping function and its associated unmapped user stores warning UI were removed. Local claim rendering was simplified, and unused imports were eliminated, reducing code complexity without altering the component's public interface.

Changes

Cohort / File(s) Change Summary
Claims List Cleanup
features/admin.claims.v1/components/claims-list.tsx		 Removed mapping validation logic (checkUserStoreMapping), eliminated unmapped user stores warning UI and state, simplified local claim row rendering with direct avatar display, and cleaned up unused imports (PRIMARY_USERSTORE, UserStoreListItem, AttributeMapping, StringUtils) and commented code blocks

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Key areas for attention:
    • Verify that checkUserStoreMapping function removal doesn't break any dependent code outside this component
    • Confirm that removing the unmapped user stores warning doesn't impact user-facing functionality
    • Check if any tests reference the deleted warning UI or mapping logic that need updates

Poem

🐰 A rabbit hops through code so neat,
Removes the checks—a clean retreat!
Claims list sparkles, warnings gone,
Simpler logic carries on. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete. The Purpose section contains only '$subject' (a placeholder), Related Issues is empty, and all checklist items are unchecked, indicating the author did not properly complete the required template. Complete the Purpose section with a clear description of why the warning popup is being removed, reference any related issues, and verify which checklist items have been completed before merging.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing the missing attribute mapping warning popup, which aligns with the core purpose shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c3e874 and eff5e87.

📒 Files selected for processing (1)
  • features/admin.claims.v1/components/claims-list.tsx (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: PasinduYeshan
Repo: wso2/identity-apps PR: 9419
File: features/admin.claims.v1/pages/local-claims-edit.tsx:92-144
Timestamp: 2025-11-17T06:13:33.923Z
Learning: In the WSO2 Identity Server deployment, the `hiddenUserStores` and `systemReservedUserStores` configuration arrays in Redux state are guaranteed to contain uppercase values as they are configured in the deployment pipeline. Therefore, direct comparison with `.toUpperCase()` values is safe without additional normalization.
📚 Learning: 2025-11-17T06:13:33.923Z 
Learnt from: PasinduYeshan
Repo: wso2/identity-apps PR: 9419
File: features/admin.claims.v1/pages/local-claims-edit.tsx:92-144
Timestamp: 2025-11-17T06:13:33.923Z
Learning: In the WSO2 Identity Server deployment, the `hiddenUserStores` and `systemReservedUserStores` configuration arrays in Redux state are guaranteed to contain uppercase values as they are configured in the deployment pipeline. Therefore, direct comparison with `.toUpperCase()` values is safe without additional normalization.

Applied to files:

  • features/admin.claims.v1/components/claims-list.tsx
🔇 Additional comments (1)
features/admin.claims.v1/components/claims-list.tsx (1)

672-683: Approved: Removed code has no external references.

Verification confirms that all removed functions and imports (checkUserStoreMapping, PRIMARY_USERSTORE, UserStoreListItem, AttributeMapping, StringUtils, userStoresNotMapped) are not referenced elsewhere in the codebase. The simplification at lines 672-683 is isolated to this file with no cross-feature impact. The straightforward AppAvatar rendering is clean and consistent.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.88%. Comparing base (833b467) to head (eff5e87).
⚠️ Report is 115 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9459   +/-   ##
=======================================
  Coverage   55.88%   55.88%           
=======================================
  Files          42       42           
  Lines        1020     1020           
  Branches      254      254           
=======================================
  Hits          570      570           
- Misses        416      450   +34     
+ Partials       34        0   -34
Flag Coverage Δ
@wso2is/core 55.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@PasinduYeshan